DYN-5319 #13441
Merged
DYN-5319 #13441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Player entry-point folders
# Conflicts: # src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs
# Conflicts: # src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs
…moPlayerFolderGroups
QilongTang
reviewed
Nov 7, 2022
Contributor
|
@LongNguyenP Changes looks fine, but would only guarantee the preference settings serialization/deserialization works, you may need to apply additional changes to make sure setting import/export works, e.g. #13476 |
mjkkirschner
reviewed
Nov 7, 2022
| // in AssemblyVersionInfo.cs so that it can be easily incremented by the | ||
| // automated build process. | ||
| [assembly: AssemblyVersion("2.17.0.2986")] | ||
| [assembly: AssemblyVersion("2.17.0.3065")] |
Member
There was a problem hiding this comment.
please avoid committing this without a good reason, it causes conflicts etc as the file is autogenerated.
mjkkirschner
reviewed
Nov 7, 2022
mjkkirschner
approved these changes
Nov 7, 2022
Member
mjkkirschner
left a comment
There was a problem hiding this comment.
It looks okay to me -
I think in general you should not use public fields like you have done and instead use auto properties if there is not a good reason.
it's also part of the MSDN c# coding conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR implements DYN-5319](https://jira.autodesk.com/browse/DYN-5319):
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Dynamo Preference Settings now include information about the user-folders in Dynamo Player and Generative Design
Reviewers
@mjkkirschner @QilongTang @saintentropy