Add docs around package scanning and notify user of infected package upload. #13235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Aug 22, 2022
| var latestPkgs = Model.GetUsersLatestPackages(); | ||
| if (latestPkgs != null && latestPkgs.maintains.Count > 0) | ||
| { | ||
| foreach (var infectedVer in latestPkgs.maintains) |
Contributor
There was a problem hiding this comment.
Would you remind me why do we need to look at each version here? I thought we only need to check the latest version of each package
Contributor
Author
There was a problem hiding this comment.
The API will return all packages with last uploaded version, so 1 version per package only.
QilongTang
reviewed
Aug 22, 2022
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Aug 22, 2022
| /// </summary> | ||
| /// <param name="obj"></param> | ||
| public void ClearDownloadToastNotification(object obj) | ||
| public void ClearToastNotification(object obj) |
Contributor
There was a problem hiding this comment.
This is API breaking but I guess you decided to break it intentionally?
Contributor
Author
There was a problem hiding this comment.
Yes to make this function a bit more generic
QilongTang
reviewed
Aug 23, 2022
| <!-- Version --> | ||
| <TextBlock | ||
| Name="version" | ||
| Name="iversion" |
Contributor
There was a problem hiding this comment.
What does iversion mean?
Contributor
Author
There was a problem hiding this comment.
infected version just a name for the text block, no relation to apple 😛
QilongTang
reviewed
Aug 23, 2022
src/DynamoCoreWpf/Views/PackageManager/PackageManagerSearchView.xaml
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Aug 23, 2022
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with some comments
QilongTang
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-4691
https://jira.autodesk.com/browse/DYN-4695
This PR adds documentation around package scanning, and now users with infected packages upload will see dismissible toast notifications when loading package manager search window.
Documentation:
Infected package toast notification with package download:-
SS of notification:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Add documentation around package scanning
Add notifications for users with infected package uploads
Reviewers
@DynamoDS/dynamo