Dealing the null color in the Preview and Watch Nodes #13131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
Contributor
|
Hi @jesusalvino - Is there any reason why the singletons are not showing color in the Watch Node? Can we please ensure that the color also propagates there too? |
Contributor
Author
|
@Amoursol poor gif resolution :/ |
Contributor
Ah - all good! Then this looks awesome, thanks @jesusalvino! |
reddyashish
reviewed
Jul 22, 2022
| return resourceDictionary["boolLabelBackground"] as SolidColorBrush; | ||
| default: | ||
| return resourceDictionary["PrimaryCharcoal200Brush"] as SolidColorBrush; | ||
| if (values[1].ToString() == "List") |
Contributor
There was a problem hiding this comment.
Use str.equals() instead of '=='
reddyashish
approved these changes
Jul 22, 2022
Contributor
reddyashish
left a comment
There was a problem hiding this comment.
looks good to me with one comment.
Contributor
|
The test WorkspaceContextMenu_TestIfOpenOnRightClick is failing randomly on some CI jobs for some unknown reason. Can you run it locally to make sure it is passing. |
Contributor
Author
|
|
reddyashish
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Set the null color in the Preview and Watch Nodes
https://jira.autodesk.com/browse/DYN-5085
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20 @filipeotero