Fix function indicator bar on output port #13108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
@filipeotero When you have time, please review this |
QilongTang
reviewed
Jul 15, 2022
| { | ||
| PortDefaultValueMarkerVisible = false; | ||
| } | ||
| PortDefaultValueMarkerVisible = node.NodeModel.CachedValue != null && node.NodeModel.CachedValue.IsFunction; |
Contributor
There was a problem hiding this comment.
Do we still need to check node.NodeModel.CachedValue.Data != null?
Contributor
Author
There was a problem hiding this comment.
When node.NodeModel.CachedValue.Data is null, IsFunction will be false and the port marker will not be visible. So I think we don't need any additional check.
Contributor
Author
|
@QilongTang Removing those unused images that were left out from #13109. Sorry I mixed up branches and just consolidated it. |
QilongTang
approved these changes
Jul 18, 2022
Contributor
|
@reddyashish Looks like there are regressions to fix |
Contributor
Author
|
This test WorkspaceContextMenu_IfSubmenuOpenOnMouseHover passes locally and passed on CI before. It just failed for some other reason. Looks flaky. Verified it locally. |
Contributor
Author
Contributor
Author
|
Latest CI job passed |
QilongTang
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Task: https://jira.autodesk.com/browse/DYN-5017
When the CachedValue is not a function, PortDefaultValueMarkerVisible should be set to false.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix function indicator bar on output port
Reviewers
@QilongTang .