Skip to content

Dyn 4929 inconsistency of terms #13077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
Jul 1, 2022
Merged

Dyn 4929 inconsistency of terms #13077

QilongTang merged 2 commits into from
Jul 1, 2022

Conversation

@RobertGlobant20
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 commented Jun 29, 2022

Purpose

Changes in the next resources in the DynamoCoreWpf project:

Package Manager
Node and Package Paths -> Node and Package File Locations
New Package Download Directory -> New Package Download Path

Security
Trusted location -> Trusted File Locations

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Changes in several resources in the DynamoCoreWpf project:

Reviewers

@QilongTang

FYIs

@RobertGlobant20
DYN-4929-InconsistencyOfTems
1db0cef 
Changes in the next resources:

Package Manager
Node and Package Paths -> Node and Package File Locations
New Package Download Directory -> New Package Download Path

Security
Trusted location -> Trusted File Locations
@RobertGlobant20
DYN-4929-InconsistencyOfTems
e49ce57 
Fixing compiler version
QilongTang
QilongTang reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it seems we will use path and location in the future and do not mention directory?

@QilongTang QilongTang added this to the 2.16.0 milestone Jun 30, 2022
@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Jun 30, 2022

So it seems we will use path and location in the future and do not mention directory?

yes, that was decided by Helena(see more details in the comments of the Jira task).

@QilongTang QilongTang merged commit a5146a4 into DynamoDS:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.16.0

Development

Successfully merging this pull request may close these issues.

2 participants

@RobertGlobant20 @QilongTang