Bugfix Vertical Margin of Note in Group #13068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed an issue where Notes in Groups display a skewed vertical margin causing the Note to overlap when in top position or push the boundary unrealistically when in bottom position inside the Group
Contributor
|
Is there a task for this? |
Contributor
In Jira it is: https://jira.autodesk.com/browse/DYN-4162 😊 |
Contributor
|
Looks good to me. I will run the self-serve before merging. |
Contributor
reddyashish
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A but-fix affecting Notes inside Groups. Notes display a consistent vertical offset, which has been addressed with this PR.
Before
After
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
@mjkkirschner
FYIs
@Amoursol