Skip to content

Conversation

@mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Jun 15, 2022

Purpose

(#12990)

  • add notifications for packages with other host at startup time
    refactor where check is
    fix existing tests

  • fix and better notification

  • add test

  • fix tests

  • comments

  • Update PackageManagerExtension.cs

  • Update PackageManagerViewExtensionTests.cs

  • typo

  • also check hosts at package load
    add test

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

raise warning at package load if package targets a different host than dynamo's current execution host.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

…t host. (DynamoDS#12990)

* add notifications for packages with other host at startup time
refactor where check is
fix existing tests

* fix and better notification

* add test

* fix tests

* comments

* Update PackageManagerExtension.cs

* Update PackageManagerViewExtensionTests.cs

* typo

* also check hosts at package load
add test
@mjkkirschner mjkkirschner added this to the 2.15.0 milestone Jun 15, 2022
@mjkkirschner
Copy link
Member Author

@mjkkirschner mjkkirschner merged commit 0cb879d into DynamoDS:RC2.15.0_master Jun 15, 2022
@mjkkirschner mjkkirschner deleted the 215warn branch June 15, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants