Address margin issues on context menu. #12890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
May 17, 2022
| <Grid RenderOptions.ClearTypeHint="Enabled"> | ||
| <ItemsPresenter x:Name="ItemsPresenter" | ||
| Margin="2" | ||
| Margin="1" |
Contributor
There was a problem hiding this comment.
Curious why it is 1 here but 0 other places?
Contributor
Author
There was a problem hiding this comment.
using zero was overlapping little bit and using a margin of 1 has no space between context menus. Probably some other styling is interfering.
QilongTang
approved these changes
May 17, 2022
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
LGTM, @zeusongit What do you think?
zeusongit
approved these changes
May 17, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is to address margin issues on node context menu, workspace context menu and node group context menu to fix the issue and to be consistent.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Address margin issues on context menu.
Reviewers
@QilongTang @zeusongit