Reopens #9485: Optimize live execution of modified graphs #12835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Engine/ProtoScript/Runners/LiveRunner.cs
Run second exection via ApplyUpdate similar to previous run model
Contributor
Author
|
@saintentropy I merged #9485 accidentally so I reverted it and am reopening this one. |
Contributor
Author
aparajit-pratap
commented
May 17, 2022
8 tasks
This was referenced Aug 14, 2022
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This implementation tries to optimize live execution of modified graphs as per the following design:
https://docs.google.com/document/d/1k7bJ8jO9QeBz5YjY5MbfFB7v7b1NJJwav7if1nfes_Y/edit
Re-execution of modified graphs is optimized only for the case of modified inputs where the inputs are primitive values only. As a future optimization we can include cases (2) a statement is redefined and (3) a function is redefined.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@saintentropy
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of