Skip to content

RC2.13.1 initial cherrypicks #12559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 8 commits into from
Jan 20, 2022
Merged

RC2.13.1 initial cherrypicks #12559

QilongTang merged 8 commits into from
Jan 20, 2022

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 20, 2022 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR cherry-picks a few bug fixes for guided tour, library, group and wire visual improvements
#12554
#12507
#12517
#12491
#12503
#12537
#12535

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

N/A

Reviewers

@reddyashish @zeusongit

FYIs

@Amoursol

filipeotero and others added 7 commits January 20, 2022 03:05
@filipeotero @QilongTang
Popup aligment (#12491)
63cbd7b
@ZiyunShang @QilongTang
Upgrade DynamoSample rvt to 2023 after Revit DDFreeze. (#12507)
3dbf969 
Co-authored-by: Ziyun Shang Application Admin <t_shanzadmin@autodesk.com>
@filipeotero @QilongTang
Fix collapase menu and popup position (#12501)
1155086
@RobertGlobant20 @QilongTang
DYN-4252-Shadow-Under-Pointer (#12503)
b4f75ea 
* DYN-4252-Shadow-Under-Pointer

I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines.
I had to add a Converter so a PointCollection can be converted to a Path.Data.

* DYN-4252-Shadow-Under-Pointer Code Review

Fixed one comment
@SHKnudsen @QilongTang
Update AnnotationViewModel.cs (#12537)
ff2e859
@SHKnudsen @QilongTang
Update librarie.min.js (#12554)
cf6b922
@SHKnudsen @QilongTang
Update AnnotationView.xaml (#12555)
3f29589
@QilongTang QilongTang added this to the 2.13.1 milestone Jan 20, 2022
@SHKnudsen @QilongTang
[DYN-4493] fix behavior with cleanup node layout feature and groups (#…
0daa190 
…12535)

* Fix nested groups auto layout bug

* fix collapsed groups auto layout issue

* fix clean up node layout issue with collapsed groups

* Update AnnotationViewModel.cs
@QilongTang QilongTang merged commit 6213399 into RC2.13.1_master Jan 20, 2022
@QilongTang QilongTang deleted the Cherry-Pick branch January 20, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reddyashish reddyashish reddyashish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.13.1

Development

Successfully merging this pull request may close these issues.

7 participants

@QilongTang @reddyashish @filipeotero @ZiyunShang @RobertGlobant20 @SHKnudsen