Skip to content

Add tests for Node Docs Generator #11960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjkkirschner merged 98 commits into from
Aug 29, 2021
Merged

Add tests for Node Docs Generator #11960

mjkkirschner merged 98 commits into from
Aug 29, 2021

Conversation

@mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Aug 23, 2021 •
edited
Loading

Purpose

  • Adds tests for node docs CLI tool.
  • Adds tests for docs browser core and host fallback docs paths.
  • tries to address an issue I saw running tests locally where a dialog from a linter test lives through all other view tests.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

SHKnudsen added 30 commits April 14, 2021 16:22
@SHKnudsen
initial commit
f9093e4
@SHKnudsen
Use CLRDLLModule
354e682
@SHKnudsen
Refactoring
3dd5ad4
@SHKnudsen
add hosts flag and other additions to frompackage
05f5984
@SHKnudsen
🧹🧹
d7fab57
@SHKnudsen
Update Program.cs
f3c2bd0
@SHKnudsen
clean up + handle overloads
bf971d0
@SHKnudsen
🧹
e5ea6c2
@SHKnudsen
Update AssemblyHandler.cs
70bf7c3
@SHKnudsen
too many things 🤯
67353b4
@SHKnudsen
Save images instead of embedding
999a0b5
@SHKnudsen
comment updates
f8c13eb
@SHKnudsen
add support for .ds files
7548c79
@SHKnudsen
comments + move to tools folder
97d29e4
@SHKnudsen
add reference to RestSharp - need to create PackageUploadRequestBody
7599dfb
@SHKnudsen
Update FromPackageFolderCommand.cs
f1f5df5
@SHKnudsen
Merge remote-tracking branch 'upstream/master' into Node-Markdown-gen…
a7b1542 
…erator-tool
@SHKnudsen
🧹
cc9705e
@SHKnudsen
Remove logger
3cc3667
@SHKnudsen
remove unused using
e372af6
@SHKnudsen
Update FromDirectoryOptions.cs
62009d5
@SHKnudsen
Update AssemblyHandler.cs
b3443ed
@SHKnudsen
Change project type + add test project
f9a5627
@SHKnudsen
remove old files
6772242
@SHKnudsen
use flag to specify ReflectionContext
6328716
@SHKnudsen
Merge remote-tracking branch 'upstream/master' into Node-Markdown-gen…
e2e3789 
…erator-tool
@SHKnudsen
few comment updates
9590d1a
@SHKnudsen
Update DocumentationBrowserViewExtensionTests.cs
dbe0a36
@SHKnudsen
ds file fixes
87fc191
@SHKnudsen
fix add isReflection flag FFIMethodAtribute
2742147
@mjkkirschner
add verbose mode and some logging when scanning dlls
087bf81 
add console colors for dictionary related errors
update readme
@mjkkirschner
add findings to known issues
e168952
@mjkkirschner
merge conflict in program.cs
835ab99
@mjkkirschner
merge fix
4ee2f82
@mjkkirschner
review comments
c228f59 
move ilibraryviewcustomization as well to dynamocore
@mjkkirschner
Merge branch 'nmgt-nometadata' into nmgtunittestsmjk
33b80bf
@mjkkirschner
fix bug if package is missing bin folder
1b23b63 
fix bug naming custom node .md files with only category name
add test dictionary and extract layout spec
remove if node and add refactored if node to test files
tests should resolve assemblies from tools bin folder and look for other dlls in core dynam bin
output tests to bin folder, but not tool
@mjkkirschner
set function type correcty for global functions
0dec3fb 
set classname on generated .md files correctly on global functions
add test for ds files
@mjkkirschner
review comments
943a9df
@mjkkirschner
Merge branch 'nmgt-nometadata' of https://github.com/mjkkirschner/Dynamo
e42e7ac 
 into nmgtunittestsmjk
@mjkkirschner
add image compression tests
5599b0d 
fix gif compression if resulting gif is larger than original.
@mjkkirschner
merge conflicts
fca6c9f
@mjkkirschner mjkkirschner added PTAL Please Take A Look 👀 and removed WIP labels Aug 25, 2021
@mjkkirschner
Copy link
Member Author

mjkkirschner commented Aug 27, 2021

there is still a failure on this branch, it looks like a fluke, but maybe it has to do with the dispatcher being left in a strange state after the new UI tests added here - will take a look.

pinzart90
pinzart90 approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@pinzart90 pinzart90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjkkirschner mjkkirschner merged commit 5e0337b into DynamoDS:master Aug 29, 2021
@mjkkirschner mjkkirschner deleted the nmgtunittestsmjk branch August 29, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzart90 pinzart90 pinzart90 approved these changes

@sm6srw sm6srw Awaiting requested review from sm6srw

@aparajit-pratap aparajit-pratap Awaiting requested review from aparajit-pratap

Assignees

No one assigned

Labels

PTAL Please Take A Look 👀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjkkirschner @pinzart90 @SHKnudsen