DYN-3777: disable linter choice in forbidden workspaces #11759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can a user get into a situation where they open a custom node which is somehow set to the wrong linter and it cannot be disabled? |
Contributor
Author
|
That should not be possible just yet, you can't set an active linter for a custom node workspace. Also, there is no "link" against a custom node workspace model and no processing will occur. |
Contributor
|
LGTM @BogdanZavu |
saintentropy
approved these changes
Jun 15, 2021
Contributor
Author
|
The test failure is unrelated to this change and it passed when the build was triggered manually from Jenkins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For now, we will only allow users to change Linter in HomeWorkspaceModels. This is temporary and we will remove this limitation in the near future.
Declarations
Check these if you believe they are true
*.resxfiles