Dyn 3541 preferences visual settings #11636

RobertGlobant20 · 2021-04-21T16:45:43Z

Purpose

I added the UI Controls for the Preferences -> Visual Settings tab.
The next functionalities were implemented:

Add new Styles
Remove existing Styles
Validate against existing Styles.
Functionality for expand/collapse WPF Expanders automatically.

I'm not including the Display Settings section since Jingyi asked me not to include it (there was no feedback from users), in case the design is ready I will include it in a different pull request.
The acceptance criteria for this task was updated some days ago so those changes will be addressed in a different pull request.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@Astul-Betizagasti

…reference (#11186)" This reverts commit c7a5e49.

…package reference (#11186)"" This reverts commit 5906c99.

I added a new workflow (issue_type_predicte.yaml) that is using the ML.NET model for predicting the issue type (source repo), so If a new issue is created in the Dynamo repo this workflow will run and will predict if is a Wishlist issue or not. If is a Wishlist issue it will be labeled as "Wishlist" and then another workflow will move the issue to the DynamoWishlist repo. If the issue is incomplete or is not valid the label "NotMLEvaluated" will be added to the issue. Also I added two scripts more, one will return the issue body in a json string and the other one will clan the issue body removing sections not used like "Dynamo Version" or "Stack Trace"

When testing the issue predicter workflow the issues labeled as Wishlist were not moved to the DynamoWishlist repo due that the "Move Issue by labels" workflow failed. There was a problem with the PAT used to label the issue, I was using the wrong one (no triggers actions).

I added the UI Controls for the Visual Settings tab. The next functionalities were implemented: - Add new Styles - Remove existing Styles - Validate against existing Styles. - Functionality for expand/collapse WPF Expanders

Moving some steps located in the PreferencesView constructor to a method.

There was an extra color in DynamoModern.xaml that is not used then I remove it.

I added a new Style for the buttons Save and Cancel, since they have a specific Style Also I modified the Style for the Add Style button since it was not following the design in hig autodesk.

Also I added a Style for the color button picker, added one text resource so it can be used in the xaml and finally I indented the xaml code.

RobertGlobant20 · 2021-04-21T16:57:31Z

This a gif of how the Visual Settings tab looks:

I included the Display Settings sections and the two toggle buttons described in the AC Also I did a modification so when the "Add Style" button is pressed the focus goes to the Group Name edit box.

RobertGlobant20 · 2021-04-21T22:13:56Z

Due that at the end I decided to include the Display Settings section, this is a gif of how it looks.

src/DynamoCoreWpf/Properties/Resources.en-US.resx

QilongTang · 2021-04-22T06:57:45Z

src/DynamoCoreWpf/DynamoCoreWpf.csproj

    <Content Include="sharpdx_direct3d11_effects_x86.dll">
      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
    </Content>
+    <Resource Include="UI\Images\trash_icon.png" />


hmm.. I was surprised that we did not use font awesome for this. Is this icon from UX?

@QilongTang I removed the png image from the project and I used the FontAwesome toolit for the trash icon, see the commit: 0fb11cd

QilongTang · 2021-04-22T07:25:04Z

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

+        Medium,
+        Large,
+        ExtraLarge
+    }


Is there a similar enum for the previous UI that we will need to obsolete? Just curious

@QilongTang I obsoleted the existing enum located in DynamoCoreWpf\UI\Prompts\ChangeScaleFactorPrompt.xaml.cs file, see commit: 0fb11cd

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

QilongTang · 2021-04-22T07:32:19Z

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs

+            foreach (Expander expander in parentGrid.Children)
+            {
+                if (expander != currentExpander)
+                    expander.IsExpanded = false;


Thanks! Although this will be covered in a different task, no harm to include and this is what I imagined how we would implement, thanks!

@Astul-Betizagasti see that I implemented the expanders functionality in case you need to use it in other places.
Thanks

QilongTang · 2021-04-22T15:10:00Z

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

+    /// <summary>
+    /// This class will contain the Enum value and the corresponding description for each radio button in the Visual Settings -> Geometry Scaling section
+    /// </summary>
+    public class GeometryScalingOptions


Would you double check if all the added public classed/properties need to be public or could be internal?

@QilongTang I added two classes StyleItem and GeometryScalingOptions, the StyleItem class need to be public since is used in public methods that are called in the code behind (If i change to internal got several errors) also the GeometryScalingOptions need to be public because there is a public property declared (GeometryScalingOptions type) and used as a binding in the PreferencesView.xaml (also is if changed to internal I got several errors).

- Removed the png image and instead use fontawesome - Removed duplicated resources for Show Edges and Isolate Selected Geometry - Obsolete a enum in ChangeScaleFactorPrompt class - Some changes in indentation and creating region for private properties

QilongTang · 2021-04-23T13:33:53Z

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

+        /// This method will remove the current Style selected from the Styles list
+        /// </summary>
+        /// <param name="groupName"></param>
+        public void RemoveStyleEntry(string groupName)


@RobertGlobant20 I guess what I was curious was more for these utility functions, seems they can be internal since only used in DynamoCoreWpf

@QilongTang I modified the accesibility level for the next public methods to internal located in the PreferencesViewModel class:

void RemoveStyleEntry

bool ValidateExistingStyle

void ResetAddStyleControl()

string GetRandomHexStringColor()

Check commit: af9a3ca
Thanks

QilongTang · 2021-04-23T13:35:12Z

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

+        /// </summary>
+        /// <param name="item1"></param>
+        /// <returns></returns>
+        public bool ValidateExistingStyle(StyleItem item1)


Same here and other placed, please go through them and validate. Just trying to avoid exposing public things if we do not have to

@QilongTang I modified the accesibility level for the next public methods to internal located in the PreferencesViewModel class:

void RemoveStyleEntry

bool ValidateExistingStyle

void ResetAddStyleControl()

string GetRandomHexStringColor()

Check commit: af9a3ca
Thanks

QilongTang

Once current comments are addressed, LGTM

Based on Aaron's comments I changed the visibility from public to internal in 4 methods located in PreferencesViewModel.

QilongTang

Please address the conflicts and check SonarQ check. Then LGTM

RobertGlobant20 added 28 commits October 28, 2020 18:29

Revert "First version with migration from packages.config to package …

5906c99

…reference (#11186)" This reverts commit c7a5e49.

Revert "Revert "First version with migration from packages.config to …

d976238

…package reference (#11186)"" This reverts commit 5906c99.

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

31af193

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

10935f9

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

85d1a54

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

aab6d6e

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

296e3c6

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

f5b3c67

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

46b41f6

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

04f46fa

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

e53925f

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

04d8914

Merge remote-tracking branch 'upstream/master'

3fa5cc8

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

d0587a6

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

6b86876

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

fbf1952

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

1c1266b

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

4512175

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

c606f38

DYN-3541-Preferences-VisualSettings

5578c25

I added the UI Controls for the Visual Settings tab. The next functionalities were implemented: - Add new Styles - Remove existing Styles - Validate against existing Styles. - Functionality for expand/collapse WPF Expanders

DYN-3541-Preferences-VisualSettings-2

77159b2

Moving some steps located in the PreferencesView constructor to a method.

DYN-3541-Preferences-VisualSettings

6acc9e6

There was an extra color in DynamoModern.xaml that is not used then I remove it.

DYN-3541-Preferences-VisualSettings

2a44f91

I added a new Style for the buttons Save and Cancel, since they have a specific Style Also I modified the Style for the Add Style button since it was not following the design in hig autodesk.

DYN-3541-Preferences-VisualSettings

56d6ef4

Also I added a Style for the color button picker, added one text resource so it can be used in the xaml and finally I indented the xaml code.

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

10ffc3d

Merge branch 'master' into DYN-3541-Preferences-VisualSettings

d5564a0

RobertGlobant20 requested a review from QilongTang April 21, 2021 16:45

DYN-3541-Preferences-VisualSettings Display Settings

ca77daa

I included the Display Settings sections and the two toggle buttons described in the AC Also I did a modification so when the "Add Style" button is pressed the focus goes to the Group Name edit box.

QilongTang reviewed Apr 22, 2021

View reviewed changes

src/DynamoCoreWpf/Properties/Resources.en-US.resx Show resolved Hide resolved

QilongTang reviewed Apr 22, 2021

View reviewed changes

src/DynamoCoreWpf/Properties/Resources.en-US.resx Show resolved Hide resolved

QilongTang reviewed Apr 22, 2021

View reviewed changes

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs Outdated Show resolved Hide resolved

QilongTang reviewed Apr 22, 2021

View reviewed changes

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs Show resolved Hide resolved

QilongTang reviewed Apr 22, 2021

View reviewed changes

QilongTang reviewed Apr 23, 2021

View reviewed changes

QilongTang requested changes Apr 23, 2021

View reviewed changes

DYN-3541-Preferences-VisualSettings Code Review2

af9a3ca

Based on Aaron's comments I changed the visibility from public to internal in 4 methods located in PreferencesViewModel.

QilongTang approved these changes Apr 24, 2021

View reviewed changes

RobertGlobant20 added 2 commits April 26, 2021 09:41

Merge branch 'master' of https://github.com/DynamoDS/Dynamo

522c870

Merge branch 'master' into DYN-3541-Preferences-VisualSettings

3a213ca

QilongTang merged commit 35b1985 into DynamoDS:master Apr 26, 2021

Dyn 3541 preferences visual settings #11636

Dyn 3541 preferences visual settings #11636

Uh oh!

Conversation

RobertGlobant20 commented Apr 21, 2021

Purpose

Declarations

Reviewers

FYIs

Uh oh!

RobertGlobant20 commented Apr 21, 2021

Uh oh!

RobertGlobant20 commented Apr 21, 2021

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RobertGlobant20 Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QilongTang left a comment

Choose a reason for hiding this comment

Uh oh!

QilongTang left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RobertGlobant20 Apr 22, 2021 •

edited

Loading