Skip to content

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Feb 8, 2021

Purpose

DYN-1976
Proposed a solution where the following DS code is translated as AST output for the If NodeModel node:

[t, f][cond ? 0 : 1];

These changes cause the node to behave as per common user expectation as well as match the ScopeIf+ clockwork package node behaviour.

This translates to building a conditional expression, an array, and an indexing expression in the AST for the NodeModel node.
Lacing and partial function support do not seem to make much sense for this new If node and have been omitted.

WIP for @reddyashish :

  • Add this functionality to a new class
  • Deprecate the old node while keeping it to maintain backward compatibility
  • Add tests

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

FYIs

@reddyashish

@reddyashish
Copy link
Contributor

Due to some authentication issue, I couldn't push my changes to this remote branch. So created a new one and closing this.

@reddyashish reddyashish closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants