Use checkboxes to select node libraries #11462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the publish package dialog to use checkboxes rather than a context menu to select which dlls are node libraries. Also adds an instructive text on top to further guide users.
QilongTang
approved these changes
Feb 8, 2021
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
LGTM. Curious if you had the chance to test it locally to check if the pkg.json has IsNodeLib set correctly
Collaborator
Author
|
@QilongTang I tested it but I had to do some code changes to run it outside Revit (had some errors otherwise) and also avoid the actual publishing. It should be equivalent to actual usage I think. |
Contributor
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes the publish package dialog to use checkboxes rather than a
context menu to select which dlls are node libraries. Also adds an
instructive text on top to further guide users.
Snapshot:
Declarations
Check these if you believe they are true
*.resxfiles