Skip to content

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 27, 2021

  • Use task run to wrap the installation body

  • Update to use sync version of API

  • Additional place to fix

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Cherrypicks #11428 #11429

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@mmisol

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

QilongTang and others added 2 commits January 27, 2021 13:46
* Use task run to wrap the installation body

* Update to use sync version of API

* Additional place to fix
Adds function SetupPythonSync to setup python synchronously
@QilongTang QilongTang merged commit 885deb4 into RC2.10.1_master Jan 27, 2021
@QilongTang QilongTang deleted the CherryPick branch January 27, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants