Cherry-pick: Fix for regression in multi-output node preview (#11266) #11274
Conversation
* fix for multi-output node preview regression * update tests * add test * revert unwanted changes * update test
| <ErrorReport>prompt</ErrorReport> | ||
| <WarningLevel>4</WarningLevel> | ||
| <Prefer32Bit>false</Prefer32Bit> | ||
| <DocumentationFile>..\..\..\bin\AnyCPU\Debug\en-US\FFITarget.xml</DocumentationFile> |
There was a problem hiding this comment.
hmm - I guess I missed this before, or didn't see it, how can we make sure this does not end up in the delivered zip? We must somehow be removing FFITarget.dll right?
There was a problem hiding this comment.
oh - it looks like we do deliver it, okay, so I guess no harm...
There was a problem hiding this comment.
I suppose we should make sure this doesn't get shipped in the future.
There was a problem hiding this comment.
yes, actually, now would be the time... but it's a bit tricky because it needs to be present for the tests, I guess we would remove it from the harvest scripts or potentially from the zipping code itself in dynamoBuildScripts repo.
There was a problem hiding this comment.
Tried looking for code in DynamoBuildScripts repo where it may be filtering out test dll's before zipping but couldn't figure out where that logic is. Will try asking Sherlyn.
No description provided.