Skip to content

[Cherry-pick] Add search functionality to Node Autocomplete window #11236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Nov 5, 2020
Merged

[Cherry-pick] Add search functionality to Node Autocomplete window #11236

QilongTang merged 1 commit into from
Nov 5, 2020

Conversation

@reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Nov 5, 2020

Purpose

This PR is to cherry pick #11192 into RC 2.9 branch.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

@reddyashish
Add search functionality to Node Autocomplete window. (DynamoDS#11192)
7221ff7 
* First commit

* Cache the seeach elements after the matching nodes have been calculated.

* Add comments

* some comments.

* Adding a test

* Addressing some comments.

* Some refactoring.

(cherry picked from commit f00b2f7)
@QilongTang QilongTang merged commit 51959dc into DynamoDS:RC2.9.0_master Nov 5, 2020
@reddyashish reddyashish deleted the 2.9 branch November 23, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reddyashish @QilongTang