Skip to content

Revert changes (#10110) #11226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 3 commits into from
Nov 3, 2020
Merged

Revert changes (#10110) #11226

QilongTang merged 3 commits into from
Nov 3, 2020

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Nov 2, 2020 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Revert changes introduced in PR #10110. DirectX will be removed from our about box as a result.
Removed only D3DCompiler_43.dll.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@mjkkirschner

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 2.10.0 milestone Nov 2, 2020
@mjkkirschner
Copy link
Member

mjkkirschner commented Nov 3, 2020

@QilongTang - I think as long as we have the directX installer in this repo we should keep the redist license around...

@QilongTang
Copy link
Contributor Author

QilongTang commented Nov 3, 2020

@mjkkirschner So the only change we need to do is remove the dll and make csproj change?

@QilongTang
Copy link
Contributor Author

QilongTang commented Nov 3, 2020

@mjkkirschner What do you think? If not confident, I will close this PR since it is currently covered by https://jira.autodesk.com/browse/DYN-3162

@mjkkirschner
Copy link
Member

mjkkirschner commented Nov 3, 2020

I think all we need to do is remove the dll and change the csproj.

@QilongTang
Copy link
Contributor Author

QilongTang commented Nov 3, 2020

@mjkkirschner Thanks for the suggestion, only removed D3DCompiler_43.dll for now. Merging.

@QilongTang QilongTang merged commit 8bd8e77 into master Nov 3, 2020
@QilongTang QilongTang deleted the RemoveD3DCompiler branch November 3, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner Awaiting requested review from mjkkirschner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @mjkkirschner