Dyn 3177 coverage core node models wpf 2 #11217
Conversation
Initial commit with 2 test methods added for covering the class SliderViewModel.cs
Added comment for two test methods
Added several tests for the next converters: - MediatoDSColorConverter - SelectionButtonContentConverter - StringToDateTimeOffsetConverter
Removing the code that was loading the CoreNodeModelsWpf.dll file
| { | ||
| Open(@"core\library\NumberSliderNodeTest.dyn"); | ||
|
|
||
| var nodeView = NodeViewWithGuid("17ef3a6e-4742-45b6-8a2e-7ec3901e7726");//NodeViewOf<DoubleSlider>(); |
There was a problem hiding this comment.
Please remove the unused code
There was a problem hiding this comment.
@QilongTang
It was a comment, then I re-wrote the comment so it doesn't look like unused code.
See the commit: 77da3f7
| using CoreNodeModelsWpf.Converters; | ||
| using Dynamo.Tests; | ||
| using NUnit.Framework; | ||
| using DSColor = DSCore.Color; |
There was a problem hiding this comment.
Please sort usings following https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards#usings
There was a problem hiding this comment.
@QilongTang I removed one using and the others were already organized according to the Coding-Standards, let me know if you have any other comment.
See the commit: 77da3f7
| { | ||
| base.Open(path); | ||
|
|
||
| DispatcherUtil.DoEvents(); |
There was a problem hiding this comment.
Do we do the override because we need to append the DoEvents() call?
There was a problem hiding this comment.
@QilongTang
Yes, you are right, the override is because we need to call the DoEvents() method so all the events in the graph are executed. I have seen the same override in many tests.
Thanks
…ModelsWpf_2"" This reverts commit 77e7b64.
Fixing some comments in the code that looked like dead code. Also I reorganized some usings.
Purpose
Increase the code coverage in the CoreNodeModelsWpf folder (second pull request).
2 test methods added for covering the class SliderViewModel.cs
Added several tests for the next converters:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @aparajit-pratap
FYIs
@alfredo-pozo