Parse long.MinValue in Design Script #11122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values of type long were parsed in a two-step process were the unsigned value was parsed first and then multiplied by its sign if present. This type of processing did not work for -9223372036854775808, as its unsigned value is not a valid long. The issue is fixed by prepending the '-' sign in case the number is negative before parsing it.
aparajit-pratap
approved these changes
Sep 16, 2020
Contributor
aparajit-pratap
left a comment
There was a problem hiding this comment.
@mmisol thanks for the fix. Just want to make sure you ran the coco.exe parser generator on the atgs in order to generate the parser.cs file and have not edited it manually.
Collaborator
Author
|
@aparajit-pratap Yes, I used the bat file named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Values of type long were parsed in a two-step process where the unsigned
value was parsed first and then multiplied by its sign if present. This
type of processing did not work for -9223372036854775808, as its
unsigned value is not a valid long. The issue is fixed by prepending
the '-' sign in case the number is negative before parsing it.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap @QilongTang
FYIs
@DynamoDS/dynamo