Changes to switch the LibG references #11049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update forked master branch
Update forked master branch
Update forked master branch
Update master forked repository
Update forked master branch
Update forked master branch
Update forked master branch
Update forked master branch
Update master forked branch
Update master forked repository
Update master forked branch
Update master forked branch
# Conflicts: # extern/LibG_224_0_1/LibG.AsmPreloader.Managed.dll # extern/LibG_224_0_1/LibG.AsmPreloader.Unmanaged.dll # extern/LibG_224_0_1/LibG.Managed.dll # extern/LibG_224_0_1/LibG.ProtoInterface.dll # extern/LibG_224_0_1/LibG.dll # extern/LibG_224_0_1/LibGCore.dll # extern/LibG_224_4_0/LibG.AsmPreloader.Managed.dll # extern/LibG_224_4_0/LibG.AsmPreloader.Unmanaged.dll # extern/LibG_224_4_0/LibG.Managed.dll # extern/LibG_224_4_0/LibG.ProtoInterface.dll # extern/LibG_224_4_0/LibG.dll # extern/LibG_224_4_0/LibGCore.dll # extern/LibG_225_0_0/LibG.AsmPreloader.Managed.dll # extern/LibG_225_0_0/LibG.AsmPreloader.Unmanaged.dll # extern/LibG_225_0_0/LibG.Managed.dll # extern/LibG_225_0_0/LibG.ProtoInterface.dll # extern/LibG_225_0_0/LibG.dll # extern/LibG_225_0_0/LibGCore.dll # extern/LibG_226_0_0/LibG.AsmPreloader.Managed.dll # extern/LibG_226_0_0/LibG.AsmPreloader.Unmanaged.dll # extern/LibG_226_0_0/LibG.Managed.dll # extern/LibG_226_0_0/LibG.ProtoInterface.dll # extern/LibG_226_0_0/LibG.dll # extern/LibG_226_0_0/LibGCore.dll # extern/ProtoGeometry/LibG.Interface.dll # extern/ProtoGeometry/ProtoGeometry.dll # extern/ProtoGeometry/en-US/ProtoGeometry.resources.dll
Contributor
aparajit-pratap
left a comment
There was a problem hiding this comment.
@alfredo-pozo couple of comments. Overall this looks great. Thanks also for updating the nuget so quickly!
Merged
Update master forked branch
# Conflicts: # extern/LibG_224_0_1/LibG.AsmPreloader.Managed.dll # extern/LibG_224_0_1/LibG.AsmPreloader.Unmanaged.dll # extern/LibG_224_0_1/LibG.Managed.dll # extern/LibG_224_0_1/LibG.ProtoInterface.dll # extern/LibG_224_0_1/LibG.dll # extern/LibG_224_0_1/LibGCore.dll # extern/LibG_224_4_0/LibG.AsmPreloader.Managed.dll # extern/LibG_224_4_0/LibG.AsmPreloader.Unmanaged.dll # extern/LibG_224_4_0/LibG.Managed.dll # extern/LibG_224_4_0/LibG.ProtoInterface.dll # extern/LibG_224_4_0/LibG.dll # extern/LibG_224_4_0/LibGCore.dll # extern/LibG_225_0_0/LibG.AsmPreloader.Managed.dll # extern/LibG_225_0_0/LibG.AsmPreloader.Unmanaged.dll # extern/LibG_225_0_0/LibG.Managed.dll # extern/LibG_225_0_0/LibG.ProtoInterface.dll # extern/LibG_225_0_0/LibG.dll # extern/LibG_225_0_0/LibGCore.dll # extern/LibG_226_0_0/LibG.AsmPreloader.Managed.dll # extern/LibG_226_0_0/LibG.AsmPreloader.Unmanaged.dll # extern/LibG_226_0_0/LibG.Managed.dll # extern/LibG_226_0_0/LibG.ProtoInterface.dll # extern/LibG_226_0_0/LibG.dll # extern/LibG_226_0_0/LibGCore.dll # extern/ProtoGeometry/LibG.Interface.dll # extern/ProtoGeometry/ProtoGeometry.dll # extern/ProtoGeometry/en-US/ProtoGeometry.resources.dll
aparajit-pratap
approved these changes
Aug 27, 2020
QilongTang
reviewed
Aug 27, 2020
| <ItemGroup /> | ||
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | ||
| <Choose> | ||
| <When Condition=" '$(OS)' != 'Unix' "> |
Contributor
There was a problem hiding this comment.
What is this section for?
Contributor
Author
There was a problem hiding this comment.
Is to decide which powershell to use, on the Linux image for the mono-build validation we have Powershell Core available, otherwise we use the windows powershell
Contributor
|
@alfredo-pozo Does this mean after this PR, local Dynamo builds will only have libG for ASM 226? |
Contributor
I think you mean @alfredo-pozo :) |
Contributor
Author
|
@QilongTang We are downloading all the nuget packages of LibG: 226, 225, 224.4 and 224, and the projects have reference to 226, does that answer your question? |
QilongTang
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
This PR has the purpose to use the new LibG nuget packages instead of the references under "extern" folder https://jira.autodesk.com/browse/DYN-1889
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap
FYIs
@QilongTang