Skip to content

Conversation

@mmisol
Copy link
Collaborator

@mmisol mmisol commented Aug 18, 2020

Purpose

Bring changes from #11010 to 2.8

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

The Python text editor now inserts spaces when the tab key is pressed
if the engine is not 'IronPython2'. This is done in order to remain
consistent with the reindent that occurs in 2to3 migration, which will
avoid errors from Python 3 complaining about mixing spaces and tabs.
@mmisol mmisol added this to the 2.8 milestone Aug 18, 2020
@mjkkirschner
Copy link
Member

LGTM

@QilongTang QilongTang merged commit 9538d39 into DynamoDS:RC2.8.0_master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants