Fix whitespace during Python 2to3 migration #10978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2to3 migration script, by design, does not take care of normalizing whitespaces. Python 3, as opposed to Python 2, enforces that spaces and tabs cannot be mixed. In order to get a working script, a reindentation is performed over the migrated content. This is only done in case the code uses tabs, otherwise there is no need to do changes to indent.
mjkkirschner
reviewed
Aug 9, 2020
| @@ -0,0 +1,182 @@ | |||
| #! /usr/bin/env python3 | |||
|
|
|||
| # Based on a script by Tim Peters, 03 October 2000. | |||
Member
There was a problem hiding this comment.
what is the license for this code?
should it be added to license / about etc?
Collaborator
Author
There was a problem hiding this comment.
Not sure. I got the original script from the Python repo, so I guess it's the same license.
mjkkirschner
approved these changes
Aug 10, 2020
QilongTang
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The 2to3 migration script, by design, does not take care of normalizing
whitespaces. Python 3, as opposed to Python 2, enforces that spaces and
tabs cannot be mixed. In order to get a working script, a reindentation
is performed over the migrated content. This is only done in case the
code uses tabs, otherwise there is no need to do changes to indent.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @mjkkirschner
FYIs
@DynamoDS/dynamo