[DYN-2827] Added Show/Hide spaces and tabs option for Python script editor. #10948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmisol
reviewed
Jul 29, 2020
src/Libraries/PythonNodeModelsWpf/Resources/ICSharpCode.PythonBinding.Resources.Python.xshd
Show resolved
Hide resolved
mmisol
reviewed
Aug 6, 2020
src/DynamoCoreWpf/ViewModels/Core/Converters/DynamoTextOptions.cs
Outdated
Show resolved
Hide resolved
mjkkirschner
reviewed
Aug 7, 2020
src/DynamoCoreWpf/ViewModels/Core/Converters/DynamoTextOptions.cs
Outdated
Show resolved
Hide resolved
mjkkirschner
reviewed
Aug 7, 2020
mjkkirschner
reviewed
Aug 7, 2020
mjkkirschner
reviewed
Aug 7, 2020
mjkkirschner
reviewed
Aug 7, 2020
mjkkirschner
reviewed
Aug 7, 2020
mjkkirschner
requested changes
Aug 10, 2020
Member
mjkkirschner
left a comment
There was a problem hiding this comment.
I think we can make the textEditor options on DynamoViewModel internal.
mjkkirschner
approved these changes
Aug 10, 2020
Member
mjkkirschner
left a comment
There was a problem hiding this comment.
If it still functions after your latest changes - LGTM
Contributor
Author
|
I am able to access the members after making them internal, and the script editor works fine. |
Contributor
|
@zeusongit Did you forgot to merge or waiting for the PR checks? |
Contributor
Author
|
@QilongTang Was waiting for the self serve, which just completed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
[DYN-2827]
Add a global setting option
Show Python Editor Whitespace Characters.Show/Hide spaces and tabs in python script editor
Preserve setting in preferences.
Add Tests
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo