Skip to content

[DYN-2755] Preview disabled nodes can be renamed with double click #10854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeusongit merged 15 commits into from
Jul 9, 2020
Merged

[DYN-2755] Preview disabled nodes can be renamed with double click #10854

zeusongit merged 15 commits into from
Jul 9, 2020

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Jul 7, 2020 •
edited
Loading

Purpose

DYN-2755
This adds the ability to the preview disabled nodes to interpret the double click event and open rename dialog box.
UI Automation Test PR: #24

Before:
preview-before

After:
preview-after2

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.

Reviewers

@DynamoDS/dynamo

Zeus1717 added 14 commits March 20, 2020 13:12
@Zeus1717
Adding benchmark test for ellipse-workflow
0af026d
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into up-m…
c7b0f1c 
…aster
@Zeus1717
DoesCurrentUserOwnPackage test update
8e56d0a
@Zeus1717
Merge remote-tracking branch 'upstream/master'
18bf789
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
d9fa3ee
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into up-m…
03ef574 
…aster
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into up-m…
e657006 
…aster
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
c254158
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into up-m…
0ea55fb 
…aster
@Zeus1717
Merge branch 'master' into up-master
6c83be5
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into up-m…
c95d539 
…aster
@Zeus1717
Add Rename event to double click on nodes with preview disabled
7288330
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into rena…
6edb455 
…me-preview
@Zeus1717
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into rena…
1e49250 
…me-preview
QilongTang
QilongTang reviewed Jul 7, 2020
View reviewed changes
@zeusongit zeusongit marked this pull request as draft July 8, 2020 00:51
@zeusongit zeusongit added the WIP label Jul 8, 2020
@zeusongit zeusongit removed the WIP label Jul 8, 2020
@zeusongit zeusongit marked this pull request as ready for review July 8, 2020 20:55
@zeusongit zeusongit requested review from QilongTang and mmisol July 8, 2020 20:56
mmisol
mmisol approved these changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zeusongit zeusongit merged commit 6256f0b into DynamoDS:master Jul 9, 2020
@zeusongit zeusongit deleted the rename-preview branch July 9, 2020 17:34
@zeusongit zeusongit restored the rename-preview branch July 9, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang Awaiting requested review from QilongTang

1 more reviewer

@mmisol mmisol mmisol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zeusongit @QilongTang @mmisol @Zeus1717