Skip to content

Conversation

@reddyashish
Copy link
Contributor

Purpose

This PR is a followup PR to the base PR(#10548).

  1. Removed the failing FirstClassFunctions as that is not being supported.
  2. The test VerifyIronPythonLoadedAssemblies was failing on self-serve because the IronPython.dll was also being copied into the "nodes" folder and the parent bin folder. This was causing an issue when the test was trying to load the dll from multiple locations. After this change, the IronPython.dll is just copied to the parent bin folder and the test passes.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@mjkkirschner @Dewb @QilongTang

@QilongTang
Copy link
Contributor

@reddyashish I remember we have a few comments code need to be cleaned up?

@reddyashish
Copy link
Contributor Author

reddyashish commented Apr 24, 2020

@QilongTang Yes, looking into it to see if we would need that

@QilongTang
Copy link
Contributor

LGTM

@QilongTang QilongTang added the LGTM Looks good to me label Apr 27, 2020
@reddyashish reddyashish merged commit a3da7cf into DynamoDS:DSCPython3 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM Looks good to me

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants