Skip to content

Conversation

@jesusHCG
Copy link

@jesusHCG jesusHCG commented Feb 7, 2020

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

manuelsaldivar525 and others added 26 commits January 9, 2020 11:37
* Add Category ExcelTest.

* Update ExcelTests.cs
….WebBrowser (#10241)

* add new project
add make core internals visible
add duplicate files as required

* build of libjswebview seems to work
added package references

* add resource files as links so dont duplicate them in repo

* move to .net 4.7.2 to avoid package ref issues
namespace adds dynamo
use new namespace to reference resources that are embedded.

* move back to 4.7 to see if we can get a build on self serve

* log msbuild version in appyveyor

* try using buildxml which restores a bit differently

* image should not be under env - bah

* revet back to nuget restore and build dynamo all

* working branch in acad

* icons from host registered streams supported now

* this functions but startup time is slow.
visibility fixed with startPage
loads acad icons from resource streams that are registered using existing resource dict

* add some stopwatch logging to resource loading
remove superflous resourcestream handler
add cache to main iconProvider entrypoint as first step in resolving icon data
use string builder to construct base64 data strings

* missed changes

* semi working lazy load - small change made to librariejs to raise event whenever any item is clicked
we also cache the original url before falling back to the default icon so we can load the real icon later.

* some cleanup

* update namespace to reflect what components are actually used
update some todos
update comments

* drop back to packges config
rename project, rename folder
rename extension class

* assembly and type names changed

* remove value tuple use
set version number to auto increment for now - keep at 1.0.x until we have a longer term plan for this project

* get rid of value tuple

* recase some methods
comments
add readme

* address review comments
…ences extension (#10280)

* First commit

* new changes

* Renaming the event

* Adding test
add new files
add comments
remove files that no longer exist
update installerSpec.exe
update installerspec source
* "LibG/ASM224,7418555f"

* "LibG/ASM224.4,918b3d73"

* "LibG/ASM225,2b68d3dd"

* "LibG/ASM226,2b308956"
* fast path for zero size heap allocation

* Cache mechanism for marshalling lookups

* Do not allocate heap stack values for class properties for CLR objects

* Test removing getter heap interaction for CLR object

* Remove unused Heap Object set

* make variables non-static

* remove GetterFunctionPointer class

Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com>
* search for property by getter if not found

* add test
* Add geometry color check for Display_ByGeometryColor_HasColoredMesh

Add geometry color check for Display_ByGeometryColor_HasColoredMesh

* Test updates

* Add Geometry Transparency Test

* Update test name
* fix for crash upon unresolved node undo

* override Equals in PortModel

* add recorded test
* DYN-2328 Add test for geometry lablling

* DYN-2328 Add test for geometry labeling

* Removing extra assignments

* updating the test and the test dyn file.

* Removing the extra variable that is not being used
This Github Action will greet Github users who submit a PR or issue first time to our repo
* Initial Commit to Update Analytics Agreement Workflow

* update

* Add unit test for deserializing analytics setting

* Update instrumentation default agreement setting in unit test

* Add more comments
* "LibG/ASM224,7418555f"

* "LibG/ASM224.4,918b3d73"

* "LibG/ASM225,2b68d3dd"

* "LibG/ASM226,5c8f1fdd"
* Disable the context menu on the library viewer.

* Zoom the libarary view to adapt the current DPI scale.

* Disable the horizontal scroll bar on the bottom of the library view.

* Disable the library view is zoomed by keyboard or mouse wheel.

* Zoom the library bar to adapt the current DPI scale.

* Hide the extra search text bar close button.
…when using display scaling (#10335)

* Disable the context menu on the library viewer.

* Zoom the libarary view to adapt the current DPI scale.

* Disable the horizontal scroll bar on the bottom of the library view.

* Disable the library view is zoomed by keyboard or mouse wheel.

* Zoom the library bar to adapt the current DPI scale.

* Hide the extra search text bar close button.

* Unsubscribing the event handler in dispose method
* Skip Analytics Client Tear down if it is not needed

* Add unit test covering analytics tear down

* Touch test naming
* Update Tracking Conditions

* Add same check to ReportingUsage

* Add properties comments
1. Unsubscribe DpiChanged event handler in the browser Dispose method.
2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time.
3. Add necessary comments.
@jesusHCG jesusHCG merged commit 2752653 into DYN-1822 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.