-
Notifications
You must be signed in to change notification settings - Fork 668
Event to handle the close operation of the workspace references extension #10271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sion. This will handle the case when the workspace is closed.
|
Started the self-serve run with these changes |
|
@reddyashish - actually I have been thinking about this a bit more: This seems weirdly specific for the Instead, what about just adding some code to the I agree in general that this behavior is actually not desirable for all extensions, so my vote would be to implement this as part of the extension logic, and not as part of DynamoCore. (if you have to add new events to homeWorkspace - like |
|
@mjkkirschner made the necessary code changes. Running the self-serve now and will add some tests to this. |
|
I have some code changes touching same files in #10279. It maybe good for us to merge in turns to avoid conflicts |
|
@reddyashish I see @QilongTang renamed the method already - LGTM - lets just be sure theres no conflicts. |
|
@reddyashish Sorry for the conflicts! Once that is resolved, you should be good to merge |
|
@QilongTang @mjkkirschner No worries, thanks for the changes. I will pull in your changes. |
4cc7371 to
1109327
Compare
|
Closing this and opening a new one to resolve the conflicts. #10280 |
Purpose
This PR is to close the workspace references extension tab when the workspace is closed so that when the user reopens the graph with no missing dependencies, the extension is hidden. It will only be shown when the workspace has missing dependencies.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang @aparajit-pratap