[Cherry-pick][DYN-2349] Close workspace references extension tab by user action an… #10235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d API (DynamoDS#10230) * DYN-2349 * Adding events and fixing the crash that was happening due to selection/deselection of the menu item. * Change to internal * Moving the Close tab event from ViewLoadedParams to WorkspaceDependencyView call * Adding extension tab name as an input parameter to the Close Extension event * Adding null check for WorkspaceReferencesMenuItem * Making the extension name string a constant * Removing the extra line
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to cherry-pick #10230 into RC2.5.0_master branch.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner