Skip to content

Add tolerance based equals node #10004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aparajit-pratap merged 14 commits into from
Sep 30, 2019
Merged

Add tolerance based equals node #10004

aparajit-pratap merged 14 commits into from
Sep 30, 2019

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Sep 23, 2019 •
edited
Loading

Purpose

JIRA: DYN-2049

  • Add tolerance based Equals node

TODO:
Add tests
Move hardcoded strings to string resources
Create icon for new node in Library view

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

mjkkirschner
mjkkirschner reviewed Sep 23, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 23, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 23, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 23, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 23, 2019
View reviewed changes
aparajit-pratap
aparajit-pratap commented Sep 24, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 25, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 25, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 25, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 25, 2019
View reviewed changes
mjkkirschner
mjkkirschner reviewed Sep 25, 2019
View reviewed changes
@aparajit-pratap aparajit-pratap added the PTAL Please Take A Look 👀 label Sep 25, 2019
@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Sep 26, 2019 •
edited
Loading

@mjkkirschner removed If node changes. Merging this. Will create separate PR for icon. Thanks for the review!

mjkkirschner
mjkkirschner reviewed Sep 28, 2019
View reviewed changes
@mjkkirschner
Copy link
Member

mjkkirschner commented Sep 28, 2019

@aparajit-pratap looks solid! - just one last question. LGTM

@mjkkirschner mjkkirschner added LGTM Looks good to me and removed PTAL Please Take A Look 👀 labels Sep 28, 2019
@aparajit-pratap aparajit-pratap merged commit 957cf14 into DynamoDS:master Sep 30, 2019
@aparajit-pratap aparajit-pratap deleted the equalsNode branch September 30, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner mjkkirschner left review comments

Assignees

No one assigned

Labels

LGTM Looks good to me

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aparajit-pratap @mjkkirschner