DYN-5106-WebView2-DocumentationBrowser Code Review

RobertGlobant20 · RobertGlobant20 · commit dc993a0e0a0f · 2022-08-15T13:42:26.000-05:00
- changing the visibility for the property FallbackDirectoryName
- renaming coreDir by docsDir
diff --git a/src/DocumentationBrowserViewExtension/DocumentationBrowserView.xaml.cs b/src/DocumentationBrowserViewExtension/DocumentationBrowserView.xaml.cs
@@ -23,7 +23,7 @@ public partial class DocumentationBrowserView : UserControl, IDisposable
         private const string VIRTUAL_FOLDER_MAPPING = "appassets";
         static readonly string HTML_IMAGE_PATH_PREFIX = @"http://";
 
-        public string FallbackDirectoryName { get; set; }
+        internal string FallbackDirectoryName { get; set; }
 
         /// <summary>
         /// Construct a new DocumentationBrowserView given an appropriate viewmodel.
diff --git a/src/DocumentationBrowserViewExtension/DocumentationBrowserViewExtension.cs b/src/DocumentationBrowserViewExtension/DocumentationBrowserViewExtension.cs
@@ -65,14 +65,14 @@ public override void Startup(ViewStartupParams viewStartupParams)
             var pathManager = viewStartupParams.PathManager;
             if (!string.IsNullOrEmpty(pathManager.DynamoCoreDirectory))
             {
-                var coreDir = new DirectoryInfo(Path.Combine(pathManager.DynamoCoreDirectory, FALLBACK_DOC_DIRECTORY_NAME));
-                fallbackDocPath = coreDir.Exists ? coreDir : null;
+                var docsDir = new DirectoryInfo(Path.Combine(pathManager.DynamoCoreDirectory, FALLBACK_DOC_DIRECTORY_NAME));
+                fallbackDocPath = docsDir.Exists ? docsDir : null;
             }
 
             if (!string.IsNullOrEmpty(pathManager.HostApplicationDirectory))
             {
-                var hostDir = new DirectoryInfo(Path.Combine(pathManager.HostApplicationDirectory, FALLBACK_DOC_DIRECTORY_NAME));
-                fallbackDocPath = hostDir.Exists ? hostDir : null;
+                var docsDir = new DirectoryInfo(Path.Combine(pathManager.HostApplicationDirectory, FALLBACK_DOC_DIRECTORY_NAME));
+                fallbackDocPath = docsDir.Exists ? docsDir : null;
             }
 
             if(this.BrowserView != null)

Original file line number	Diff line number	Diff line change
`@@ -65,14 +65,14 @@ public override void Startup(ViewStartupParams viewStartupParams)`
`65`	`65`	`var pathManager = viewStartupParams.PathManager;`
`66`	`66`	`if (!string.IsNullOrEmpty(pathManager.DynamoCoreDirectory))`
`67`	`67`	`{`
`68`		`- var coreDir = new DirectoryInfo(Path.Combine(pathManager.DynamoCoreDirectory, FALLBACK_DOC_DIRECTORY_NAME));`
`69`		`- fallbackDocPath = coreDir.Exists ? coreDir : null;`
	`68`	`+ var docsDir = new DirectoryInfo(Path.Combine(pathManager.DynamoCoreDirectory, FALLBACK_DOC_DIRECTORY_NAME));`
	`69`	`+ fallbackDocPath = docsDir.Exists ? docsDir : null;`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`if (!string.IsNullOrEmpty(pathManager.HostApplicationDirectory))`
`73`	`73`	`{`
`74`		`- var hostDir = new DirectoryInfo(Path.Combine(pathManager.HostApplicationDirectory, FALLBACK_DOC_DIRECTORY_NAME));`
`75`		`- fallbackDocPath = hostDir.Exists ? hostDir : null;`
	`74`	`+ var docsDir = new DirectoryInfo(Path.Combine(pathManager.HostApplicationDirectory, FALLBACK_DOC_DIRECTORY_NAME));`
	`75`	`+ fallbackDocPath = docsDir.Exists ? docsDir : null;`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`if(this.BrowserView != null)`