fix: Runtime error when milestone is assigned to (None) in tmpo manual
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a nil check for entry.MilestoneName before dereferencing to prevent potential runtime panics when MilestoneName is nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a nil check for entry.MilestoneName before dereferencing to prevent potential runtime panics when MilestoneName is nil.
Pull Request Checklist
mainbranch of tmpo.Closes #50
Description
This pull request makes a small but important fix to the milestone display logic in the manual command. It ensures that the code checks if
MilestoneNameis not nil before dereferencing it, preventing potential runtime panics.