[added] Mobile leaderboard page #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the leaderboard page to improve modularity and maintainability by splitting the UI into separate desktop and mobile components.
- Introduces new components: DesktopLeaderboard, MobileLeaderboard, and MobileLeaderboardPodium.
- Adds helper functions and types for username truncation and leaderboard data handling.
- Removes redundant inline code in favor of reusable components.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/(main)/leaderboard/page.tsx | Replaces inline leaderboard rendering with DesktopLeaderboard and MobileLeaderboard components. |
| app/(main)/leaderboard/_components/desktop-leaderboard.tsx | Implements the desktop view of the leaderboard using the new helper for username truncation. |
| app/(main)/leaderboard/_components/mobile-leaderboard.tsx | Implements the mobile view of the leaderboard by assembling podium components and user info. |
| app/(main)/leaderboard/_components/mobile-leaderboard-podium.tsx | Displays individual user podiums on mobile with responsive username truncation. |
| app/(main)/leaderboard/_components/leaderboard-helpers.ts | Provides type definitions and a helper function for truncating usernames. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
divinewton
approved these changes
Apr 14, 2025
divinewton
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the leaderboard component, including the addition of separate desktop and mobile views, and refactoring of existing code for improved modularity and maintainability. The most important changes include the creation of new components for the leaderboard views, the addition of helper functions, and the removal of redundant code.
New Components:
app/(main)/leaderboard/_components/desktop-leaderboard.tsx: Added a newDesktopLeaderboardcomponent to display the leaderboard for desktop users.app/(main)/leaderboard/_components/mobile-leaderboard.tsx: Added a newMobileLeaderboardcomponent to display the leaderboard for mobile users.app/(main)/leaderboard/_components/mobile-leaderboard-podium.tsx: Added a newMobileLeaderboardPodiumcomponent to display individual user podiums on mobile.Helper Functions and Types:
app/(main)/leaderboard/_components/leaderboard-helpers.ts: AddedLeaderboardPropsinterface andtruncateUsernamefunction to handle leaderboard data and username truncation.Code Refactoring:
app/(main)/leaderboard/page.tsx: Removed inline leaderboard rendering code and replaced it with the newDesktopLeaderboardandMobileLeaderboardcomponents. Also removed the redundanttruncatefunction. [1] [2] [3]