[added] Visual indicator for when you are able to increase your streak #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
components/navbar/navbar.tsx:111
- The current condition applies the fill class when the user cannot increase their streak, which might be the inverse of the intended behavior based on the PR description. Please verify that the logic aligns with the desired visual indicator behavior.
!canUserIncreaseStreak(user.lastPlayTimestamp) ? "fill-[#1C0F13]" : ""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new utility function to check if a user can increase their daily challenge streak and integrates this function into the
Navbarcomponent. The most important changes include adding the new function, modifying theNavbarcomponent to use this function, and updating the imports accordingly.New Utility Function:
hooks/use-daily-challenge-check.tsx: Added thecanUserIncreaseStreakfunction to determine if a user can increase their streak based on the last time they played the daily challenge.Integration in Navbar Component:
components/navbar/navbar.tsx: Imported thecanUserIncreaseStreakfunction.components/navbar/navbar.tsx: Modified theFlamecomponent to conditionally apply a CSS class based on the result ofcanUserIncreaseStreak.Can Increase Streak:
Can no longer increase streak:
