[fix] Streak and Daily challenge not updating correctly #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
convex/users.ts:130
- [nitpick] Both lastDailyChallengeCompletion and lastPlayTimestamp are updated in finishDailyChallenge. Please confirm if updating the legacy field is still required or if it can be removed to avoid potential data inconsistency.
lastPlayTimestamp: now,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
convexmodule to add and utilize a newlastPlayTimestampfield in the user schema, which helps in tracking the last time a user played. The most important changes include modifications to the schema definition and updates to thefinishDailyChallengeandupdateStreakmutations to use this new field.Schema updates:
convex/schema.ts: AddedlastPlayTimestampas an optional number field in the user schema.Mutation updates:
convex/users.ts: Updated thefinishDailyChallengemutation to setlastPlayTimestampto the current time when a daily challenge is completed.convex/users.ts: Modified theupdateStreakmutation to uselastPlayTimestampinstead oflastDailyChallengeCompletionfor determining the last play time. [1] [2]