[added] Streak System #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
convex/users.ts:175
- Ensure that incrementing the streak when the time difference is exactly 24 hours is the intended behavior, as this boundary condition could lead to an unexpected streak increment.
+ if (timeSinceLastPlay <= 24 * 60 * 60 * 1000) {
app/(gameplay)/game/_context/GameContext.tsx:145
- [nitpick] Consider awaiting the updateStreak mutation to handle potential errors or explicitly document that its fire-and-forget usage is intentional.
updateStreak({ clerkId: user.clerkId });
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the game context and user management systems, focusing on updating user streaks and handling inactive users. The most important changes include adding a mutation to update user streaks, creating a cron job to reset inactive streaks, and modifying the schema for user data.
Game Context Changes:
updateStreakmutation to theGameProviderto update user streaks after each round. [1] [2]User Management Changes:
lastParticipationDatewithlastPlayedTimestampfor better timestamp handling.internalMutationfor updating streaks with a more detailedmutationthat handles streak updates based on the last played timestamp.internalMutationto reset the streaks of inactive users.Reminder:
To test these changes locally, you need to run
to update your backend instance with the newest code.
Let me know if you get an error, and I can help you. It is because the user schema changed, so you have to do a hack to get it updated.