[added] Better incorrect guess screen #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
app/(gameplay)/game/_context/GameContext.tsx:117
- The use of 'find' to select an incorrect image may arbitrarily pick the first non-matching URL. Verify that the ordering of currentImageIds and currentImageSrcUrls is consistent to ensure the correct wrong image is chosen.
setIncorrectImageSrcUrl(currentImageSrcUrls.find((_, index) => currentImageIds[index] !== result.correctImageId) || null);
app/(gameplay)/game/_components/ImageGame.tsx:135
- Using a non-null assertion for incorrectImageSrcUrl may lead to runtime errors if the value is null. Consider adding a null check or fallback before rendering the image.
<Image src={incorrectImageSrcUrl!} layout="fill" objectFit="cover" draggable={false} alt="Image Option" className="absolute inset-0 w-full h-full object-cover" />
divinewton
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
ImageGamecomponent and theGameContextto handle incorrect image URLs and improve the user interface based on the correctness of the selected image. The most important changes are summarized below:Updates to
ImageGameComponent:incorrectImageSrcUrlto the destructured properties to manage incorrect image URLs.wasCorrectstate. [1] [2] [3]Updates to
GameContext:incorrectImageSrcUrlto theIGameContextinterface to store the URL of the incorrect image.GameProviderto manage the state ofincorrectImageSrcUrland set it based on the game result. [1] [2] [3] [4] [5]