[fix] Accessibility improvements #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divinewton
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several accessibility improvements and a minor structural change to the heading component. The main changes involve adding
aria-labelattributes to various buttons and links to improve screen reader support and changing anh3tag to anh2tag for better semantic structure.These issues were pointed out by PageSpeed Insights on this report:
https://pagespeed.web.dev/analysis/https-playaidentify-com/39xadkllub?form_factor=desktop
Accessibility Improvements:
components/footer.tsx: Addedaria-labelattributes to the email and GitHub repository links for better screen reader support.components/navbar/navbar.tsx: Addedaria-labelattributes to buttons for expanding the page navigator, user settings, help popup, leaderboard page, and admin dashboard to enhance accessibility. [1] [2] [3]components/version-button.tsx: Addedaria-labelattributes to the release notes link and button to improve screen reader accessibility.Structural Change:
app/(marketing)/_components/heading.tsx: Changed anh3tag to anh2tag for better semantic structure and improved accessibility.