Skip to content

Find another location where get_ikind results in an error#41

Merged
Dudeldu merged 2 commits intomasterfrom
fix-ikind-issue-in-cast-check
Jul 19, 2022
Merged

Find another location where get_ikind results in an error#41
Dudeldu merged 2 commits intomasterfrom
fix-ikind-issue-in-cast-check

Conversation

@Dudeldu
Copy link
Copy Markdown
Owner

@Dudeldu Dudeldu commented Jul 15, 2022

I rare cases (sv-comp: floats-cbmc-regression/float21.yml) the check on is_safe_cast throws an exception due to a call to get_ikind on potentially float arguments inside IntDomain.Size.is_cast_injective. Now we directly ignore all casts that have a float-like part.

@Dudeldu Dudeldu requested a review from FelixKrayer July 15, 2022 14:10
FelixKrayer
FelixKrayer previously approved these changes Jul 18, 2022
@FelixKrayer
Copy link
Copy Markdown
Collaborator

Do you want to add the svcomp test? I personally do not think it's really necessary here

@Dudeldu Dudeldu force-pushed the fix-ikind-issue-in-cast-check branch from 4f241da to ff56a9e Compare July 18, 2022 13:57
@FelixKrayer
Copy link
Copy Markdown
Collaborator

I trust, you know what you are doing with the safeness of casts from Float to Int, but seems reasonable

@Dudeldu Dudeldu merged commit d31be72 into master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants