Enable Secure System Time #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Initially I thought that it was better to rely on the app-layer to infer the tsc which would add more security (e.g make sure the host isn't delaying) but after some thinking the app-layer can still do this extra security check with this approach + it seems TDs are not actually allowed to modify the vTSC iiuc from the module spec. Just putting this here for context in case some other folks were thinking about this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the doc from Intel, the TSC inside TD is secure if it is synchronized with NTS.
This PR makes the TD system time secure by:
TODO: Terminate the system upon prolonged chrony synchronization failure to prevent clock drift.