Skip to content

supervisor: Fix bug in log span #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kvinwang merged 1 commit into from
Jun 3, 2025
Merged

supervisor: Fix bug in log span #192

kvinwang merged 1 commit into from
Jun 3, 2025

Conversation

@kvinwang
Copy link
Collaborator

@kvinwang kvinwang commented Jun 3, 2025

A supervisor.log file grew unexpectedly large due to improper tracing span implementation in async context. The entered span's crossing of the yield point led to span confusion in async tasks, resulting in tons of spans being squashed into single log entries.

  let span = tracing::info_span!("process", id = process_uuid);
  let _enter = span.enter();
  let (killed, result) = wait_on_process(process, kill_rx).await; // The entered span crossed this yield point.

This PR fixes it.

@kvinwang kvinwang merged commit 8aa3457 into master Jun 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvinwang