-
Notifications
You must be signed in to change notification settings - Fork 64
Better naming for components #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why does
Another approach would be to symlink stack.sock to tappd.sock, and serve the same API with backward compatibility. Which one do you think is better? |
It isn't just key materials. The two types of key get different pubkeys and the pubkey is included in the cert chain or signature chain which proves the key's origin and owner(app-id).
Since all of the APIs have changed, I think a hard separation might be better as it forces the new apps to use the new APIs so that we can drop the old API support earlier. What's your preference? |
This PR implements the Dstack part of issue Phala-Network/phala-cloud#25
Terminology Mapping
tappddstack-guest-agent/var/run/tappd.sock/var/run/dstack.sockhttp://localhost/prpc/Tappd.<Method>http://localhost/<Method>DeriveK256Key(...)GetKey(...)DeriveKey(...)GetTlsKey(...)TdxQuote(...)RawQuote(...)GetQuote(report_data)TappdClientDstackClienttproxydstack-gatewayteepoddstack-vmmkmsdstack-kmsNote
The previous tappd API is still available at
/var/run/tappd.sock. The renamed APIs serves on/var/run/dstack.sock.