ui: rework repository item layout#1166
Merged
Merged
Conversation
- Use the switch to toggle enabled state instead of pressing on the item. - Pressing on the item edits it now instead of having to long press the item. Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Contributor
Author
|
I have opened this as draft, because this was the state I currently had. @Iamlooker suggested some UI adjustments, which I will implement too so the two approaches can be compared. |
Member
|
Not gonna lie, your current design does look fire. I feel inclined towards this now but if my requested change is not big maybe you can try that as well and we will decide from there |
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Contributor
Author
|
Here is the v2 as discussed on Matrix: Light
Dark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is also preparation to show a repo icon once that is implemented.
Before
After
Blueprint with repo icon