Fix SA1011 for function pointer unmanaged calling convention list #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
approved these changes
Nov 30, 2020
Member
sharwell
left a comment
There was a problem hiding this comment.
I suspect this may need .NET 5 reference assemblies, but if the build passes as-is then this works for me.
Codecov Report
@@ Coverage Diff @@
## master #3254 +/- ##
=======================================
Coverage 94.39% 94.40%
=======================================
Files 967 968 +1
Lines 108429 108452 +23
Branches 3675 3675
=======================================
+ Hits 102356 102379 +23
Misses 5143 5143
Partials 930 930 |
Member
|
Looks like it worked. Thanks @NextTurn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.