Skip to content

Improve WAV export dialog#346

Merged
Gumball2415 merged 3 commits intomainfrom
fix-wav-export-gui
Jun 20, 2025
Merged

Improve WAV export dialog#346
Gumball2415 merged 3 commits intomainfrom
fix-wav-export-gui

Conversation

@nyanpasu64
Copy link
Copy Markdown
Collaborator

@nyanpasu64 nyanpasu64 commented Jun 3, 2025

not finished, wish i could add fadeout, but i don't know how to add a gui control for that without positioning dialog elements through guesswork (which feels bad).

  • suspected bug: OnEnChangeSeconds triggers during dialog initialization, resulting in focusing the wrong radio.

This pull request aims to improve WAV export dialog.

Changes in this PR:

  • Fix spelling error in WAV export dialog
  • Pick song length mode when typing length time in WAV export dialog
  • Fix pushing to main thread receive queue from wrong thread

@nyanpasu64 nyanpasu64 force-pushed the fix-wav-export-gui branch from 48dd3b1 to 0656259 Compare June 5, 2025 06:47
@nyanpasu64 nyanpasu64 marked this pull request as ready for review June 13, 2025 10:49
@nyanpasu64 nyanpasu64 closed this Jun 14, 2025
@nyanpasu64 nyanpasu64 reopened this Jun 14, 2025
@nyanpasu64 nyanpasu64 force-pushed the fix-wav-export-gui branch from 0656259 to 3abc9e1 Compare June 14, 2025 03:16
@Gumball2415 Gumball2415 merged commit 5b81145 into main Jun 20, 2025
16 checks passed
@nyanpasu64 nyanpasu64 deleted the fix-wav-export-gui branch June 20, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants