Stop rejecting valid files using features missing from vanilla FT#150
Merged
Gumball2415 merged 1 commit intomasterfrom Jul 28, 2022
Merged
Stop rejecting valid files using features missing from vanilla FT#150Gumball2415 merged 1 commit intomasterfrom
Gumball2415 merged 1 commit intomasterfrom
Conversation
Previously, in modules with many instrument sequences for a given chip, or if any N163 instrument contained more than 16 waves or was placed ≥ 128, Dn-FT would allow creating and saving these modules, but would reject them upon reopening. This is highly undesirable behavior, and resulted in some people being unable to open modules from the 2022 demo compo. Since vanilla FT is dead, remove the vanilla checks altogether. This removes the "official" validation level, as well as all checks that turned on at that level, since they could all reject valid documents being saved and reopened. For users who already set their validation levels to "official" or "strict", this maps to the new "strict" validation level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in modules with many instrument sequences for a given chip, or if any N163 instrument contained more than 16 waves or was placed ≥ 128, Dn-FT would allow creating and saving these modules, but would reject them upon reopening. This is highly undesirable behavior, and resulted in some people being unable to open modules from the 2022 demo compo.
Since vanilla FT is dead, remove the vanilla checks altogether. This removes the "official" validation level, as well as all checks that turned on at that level, since they could all reject valid documents being saved and reopened (examples at vanilla-compat.zip).
For users who already set their validation levels to "official" or "strict", this maps to the new "strict" validation level.