Skip to content

Remove unused files, add headers to CMakeLists.txt#142

Merged
Gumball2415 merged 4 commits intomasterfrom
add-headers-to-cmake
May 28, 2022
Merged

Remove unused files, add headers to CMakeLists.txt#142
Gumball2415 merged 4 commits intomasterfrom
add-headers-to-cmake

Conversation

@nyanpasu64
Copy link
Copy Markdown
Collaborator

@nyanpasu64 nyanpasu64 commented May 28, 2022

Adding headers to CMakeLists.txt fixes finding or renaming symbols in Qt Creator, which would previously exclude occurrences in header files not listed in CMakeLists.txt add_executable().

I hand-edited the Visual Studio project files, and cannot guarantee I didn't forget to add or remove anything.

legacy/emu2149.h is only used by nes_fme7.h (which is unused). Keep it
for now.
Ideally I'd put .h before .cpp, but that's difficult to automate.
@nyanpasu64 nyanpasu64 marked this pull request as ready for review May 28, 2022 14:36
@Gumball2415 Gumball2415 merged commit d581601 into master May 28, 2022
@nyanpasu64 nyanpasu64 deleted the add-headers-to-cmake branch May 29, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants