Target volume slide effect (Nxy)#109
Merged
Gumball2415 merged 3 commits intoDn-Programming-Core-Management:masterfrom Aug 4, 2022
Merged
Target volume slide effect (Nxy)#109Gumball2415 merged 3 commits intoDn-Programming-Core-Management:masterfrom
Gumball2415 merged 3 commits intoDn-Programming-Core-Management:masterfrom
Conversation
Collaborator
|
This is unrelated to whether this PR gets accepted or not, but personally I'm interested in adding duration-target effects for volume, pitch, and portamento, rather than slope-duration/target. Either this would be a separate effect from the existing ones, or replace the existing slope or slope-target effects in modules with a new setting enabled. Is that type of effect viable to implement in the NSF driver, and if so can you open a separate PR for that? |
Contributor
Author
|
There's no really good way to do that in 1) a way that fits into a single byte parameter, 2) is intuitive to use, and 3) works for consistently for all effects. Any solution would be really cumbersome to implement without rewriting large parts of the driver. |
…ide target is reached, matching behaviour in the tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a target volume slide effect as Nxy, x = speed, y = target volume. The NSF drivers have been updated accordingly.
I designed it to be a volume-equivalent of the portamento effects Qxy/Rxy (which means I guess you also could consider Axy the volume-equivalent of 1xx/2xx). This means that the effect stops once the target volume is reached, or if the volume is set to a different value. The effect is also mutually exclusive with Axy as they both modify the channel volume.
I've tested both the tracker and NSF export for all channels that support the channel volume.