OLD DRAFT Intended for pre-DistroAV-rebrand 6.0.0 but now deprecated by `6.0.0_actual` rebranded branch; keep and resolve diffs before `6.0.0_actual` release #960

paulpv · 2024-01-11T05:33:15Z

Tweak libndi-get.sh
Tweak CMakeLists.txt
Tweak readme
Bump OBS-NDI version to 6.0.0
Rebrand from Stéphane Lepin stephane.lepin@gmail.com to OBS-NDI Project obsndi@obsndiproject.com
Add Discord link in app
Major cleanup of strings
Update to NDI SDK 6.0.1
Update Config logic to match obs-websocket
Add a --obs-ndi-verbose command-line option to print out 'a' and 'v' for audio and video packets respectively

Also making Config code similar to `obs-websocket`'s code

...and not legacy NDI 4 `ndi_hwaccel`. According to their docs and forum posts there is supposedly no way to un-set this.

The current code either packages a .msi **or** generates a .zip. Many users prefer the zip (and it has the benefit of mitigating code signing warnings). This change always generates the .zip file. If `-BuildInstaller` is also specified then is **also** builds a .msi.

Also having urls launch a much more consistent way in output-settings, obs-ndi-filter, and obs-ndi-source. Commenting out currently unused obs_log(...) method. That method allocates and frees a formatting template every time it is called. All just to prefix the plugin module name in a `blog` output. obs-ndi `blog` already exhaustively prefix the module name, so this convenience function is unnecessary for now. If logging consistency ever gets out of hand then this could be uncommented and used.

Also making Config code similar to `obs-websocket`'s code

...and not legacy NDI 4 `ndi_hwaccel`. According to their docs and forum posts there is supposedly no way to un-set this.

The current code either packages a .msi **or** generates a .zip. Many users prefer the zip (and it has the benefit of mitigating code signing warnings). This change always generates the .zip file. If `-BuildInstaller` is also specified then is **also** builds a .msi.

Also having urls launch a much more consistent way in output-settings, obs-ndi-filter, and obs-ndi-source. Commenting out currently unused obs_log(...) method. That method allocates and frees a formatting template every time it is called. All just to prefix the plugin module name in a `blog` output. obs-ndi `blog` already exhaustively prefix the module name, so this convenience function is unnecessary for now. If logging consistency ever gets out of hand then this could be uncommented and used.

Trouffman · 2024-05-14T13:25:38Z

data/locale/en-US.ini

+NDIPlugin.SourceProps.LatencyMode.Low="Low"
+NDIPlugin.SourceProps.LatencyMode.Lowest="Lowest (unbuffered; Alpha channel not supported)"
 NDIPlugin.SourceProps.Audio="Enable audio"
 NDIPlugin.SourceProps.PTZ="Pan Tilt Zoom"


This is confusing when displayed in the UI.
Should be : PTZ control

Trouffman

Seem that the basics are working.
I have tested getting & sending on

MacOS - Apple Silicon

Left to test : win10-11 & linux

PTZ could not be tested.

This would fix some case where an old version of the plugin is used but NDI6 is installed. This is because it is not using the env. variable on linux.

Jaybonaut · 2024-07-03T19:42:11Z

This would have been nice if it was released for the rename

paulpv · 2024-07-11T02:47:50Z

Update on this: I am aware [trust me, very aware] that this PR... my own... has been open since 2024/01/10.
I want to get this version released too; I dare say more than anyone else! :)

A lot has happened since Jan: a little bit personal/work related, but mostly talking about this plugin in general.

It mostly all started 2024/02 when our Apple Developer account did not auto renew.

The Apple Developer account is only needed when signing official releases, so I never noticed this while I was working on this 6.0.0 branch.

I first noticed the expired account on 2024/04/28 when I was trying to release a https://github.com/DistroAV/DistroAV/releases/tag/4.13.2 hotfix.

@Palakis and I looked into how this open source project could qualify for an Apple Developer fee waiver:
https://developer.apple.com/support/fee-waiver/

Requirements
To be eligible, you must:

Be a legal entity with a status as a nonprofit organization1, accredited educational institution2, or government entity;

Not be an individual, sole proprietor, or single-person business;

Not have signed the Paid Applications Agreement (Schedules 2 and 3 of the Developer Program License Agreement) to offer paid apps or in-app purchases through the App Store (or have terminated the Paid Applications Agreement if you signed it previously); and

Not otherwise sell digital goods or services through any of your apps.
In addition, if you operate an alternative app marketplace on iOS in the European Union (EU), you may only distribute apps from developers who have also received this same fee waiver.

So that same day, 2024/04/28, I started the process of forming a OBS-NDI PROJECT non-profit [company].

On 2024/05/01 @tt2468 was generous to donate the money to pay for an Apple Developer account to buy us another year.

On 2024/05/10 the obsproject.com reached out to us because they heard that I was forming a non-profit with the name "OBS" in it, and they politely asked us to rename not just our non-profit, but they want every "OBS*" plugin to rename themself.

That is when things spiraled out of control, and I won't go into too much more detail.

Point is, this project is far from dead and I am still actively working on it.

If you have read this far and use this plugin and would like to help us out, please consider making a donation at https://opencollective.com/distroav so that we can cover the cost of regular expenses.

Stream on!

Update libndi-get.sh - fixed backward compatibility link This fix an issue in the install script that would force a backward use of the v5 instead of the v6 and create installation issues.

Trouffman · 2024-09-03T20:48:15Z

@paulpv did you finished merging back the diff - Aka : Can we close this PR / clean-up ?

paulpv · 2024-10-27T18:47:31Z

6.0.0 has been released, so this PR is no obsolete; will close

paulpv and others added 24 commits November 14, 2023 01:25

Add obs-ndi plugin version to NDI Output Settings dialog title

fbf7c7d

Check for Qt >= 6 during obs_module_load

7740931

Tweak readme a little

69bdbe8

Fix title in NDI Output Settings

cf36163

Add --obs-ndi-verbose command-line

3d78040

Also making Config code similar to `obs-websocket`'s code

Add missing verbose a/v logging for non-framesync

bb7a1c8

Update hw_accel to use NDI 5 ndi_video_codec metadata

61f4d05

...and not legacy NDI 4 `ndi_hwaccel`. According to their docs and forum posts there is supposedly no way to un-set this.

Fix [lack of] char* casting error

e92ff52

github: update FUNDING file

c1217de

[FIX] Transparent background for NDI latency mode low is back.

c489aad

[UPDATE] Added disclaimer to latency mode 'Lowest'

2e848bf

[UPDATE] update version number

33d9226

Add obs-ndi plugin version to NDI Output Settings dialog title

919ca70

Check for Qt >= 6 during obs_module_load

a38855b

Tweak readme a little

22929ea

Fix title in NDI Output Settings

d4621ac

Add --obs-ndi-verbose command-line

18b027e

Also making Config code similar to `obs-websocket`'s code

Add missing verbose a/v logging for non-framesync

64dcdd8

Update hw_accel to use NDI 5 ndi_video_codec metadata

7c6dce7

...and not legacy NDI 4 `ndi_hwaccel`. According to their docs and forum posts there is supposedly no way to un-set this.

Fix [lack of] char* casting error

3dea004

paulpv force-pushed the develop branch 3 times, most recently from 23d2148 to 36330b5 Compare January 13, 2024 04:03

ci: Fix formatting build break

c44d97e

paulpv force-pushed the develop branch from 36330b5 to c44d97e Compare January 13, 2024 04:10

Merge branch 'develop' into develop

715ca40

Trouffman reviewed May 14, 2024

View reviewed changes

Trouffman reviewed May 15, 2024

View reviewed changes

Trouffman added this to the 6.0.0 milestone May 16, 2024

paulpv mentioned this pull request May 21, 2024

New Feature: Check For Update #1028

Merged

Trouffman mentioned this pull request Jun 10, 2024

Hidden NDI sources are using CPU power and network bandwidth #270

Closed

Fix install script linux

4fc32df

This would fix some case where an old version of the plugin is used but NDI6 is installed. This is because it is not using the env. variable on linux.

cue108 and others added 3 commits July 11, 2024 17:15

Update libndi-get.sh - fixed backward compatibility link

629e190

Merge pull request #1040 from cue108/patch-1

f0da1cb

Update libndi-get.sh - fixed backward compatibility link This fix an issue in the install script that would force a backward use of the v5 instead of the v6 and create installation issues.

fix typo in libndi-get.sh

9b2a44a

paulpv removed the request for review from tt2468 July 31, 2024 09:44

paulpv marked this pull request as draft July 31, 2024 09:44

paulpv changed the title ~~Preparing for 6.0.0 release~~ OLD DRAFT pre-rebrand intended for 6.0.0 but now deprecated; keeping until 6.0.0_actual is released Aug 8, 2024

paulpv changed the title ~~OLD DRAFT pre-rebrand intended for 6.0.0 but now deprecated; keeping until 6.0.0_actual is released~~ OLD DRAFT Intended for pre-DistroAV-rebrand 6.0.0 but now deprecated by 6.0.0_actual; keep and resolve diffs before 6.0.0_actual release Aug 8, 2024

Merge branch 'master' into develop

8ebdc12

paulpv changed the base branch from master to 6.0.0_actual August 10, 2024 04:20

paulpv force-pushed the develop branch 3 times, most recently from 5bdbe08 to b873728 Compare August 10, 2024 05:23

Merge branch '6.0.0_actual' into develop

3398993

paulpv force-pushed the develop branch from b873728 to 3398993 Compare August 10, 2024 05:26

Base automatically changed from 6.0.0_actual to master August 16, 2024 06:26

Merge branch 'master' into develop

fe1bf41

paulpv closed this Oct 27, 2024

paulpv deleted the develop branch October 27, 2024 18:53

RayneYoruka mentioned this pull request Feb 21, 2025

[Bug]: NDI transparency does not work when using low/lowest latency #937

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

OLD DRAFT Intended for pre-DistroAV-rebrand 6.0.0 but now deprecated by `6.0.0_actual` rebranded branch; keep and resolve diffs before `6.0.0_actual` release #960

OLD DRAFT Intended for pre-DistroAV-rebrand 6.0.0 but now deprecated by `6.0.0_actual` rebranded branch; keep and resolve diffs before `6.0.0_actual` release #960

Uh oh!

paulpv commented Jan 11, 2024 •

edited

Loading

Uh oh!

Trouffman May 14, 2024

Uh oh!

Trouffman left a comment

Uh oh!

Jaybonaut commented Jul 3, 2024

Uh oh!

paulpv commented Jul 11, 2024

Uh oh!

Trouffman commented Sep 3, 2024

Uh oh!

paulpv commented Oct 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

OLD DRAFT **Intended for pre-DistroAV-rebrand 6.0.0** but now deprecated by 6.0.0_actual rebranded branch; keep and resolve diffs before 6.0.0_actual release #960

OLD DRAFT **Intended for pre-DistroAV-rebrand 6.0.0** but now deprecated by 6.0.0_actual rebranded branch; keep and resolve diffs before 6.0.0_actual release #960

Uh oh!

Conversation

paulpv commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trouffman May 14, 2024

Choose a reason for hiding this comment

Uh oh!

Trouffman left a comment

Choose a reason for hiding this comment

Uh oh!

Jaybonaut commented Jul 3, 2024

Uh oh!

paulpv commented Jul 11, 2024

Uh oh!

Trouffman commented Sep 3, 2024

Uh oh!

paulpv commented Oct 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

OLD DRAFT Intended for pre-DistroAV-rebrand 6.0.0 but now deprecated by `6.0.0_actual` rebranded branch; keep and resolve diffs before `6.0.0_actual` release #960

OLD DRAFT Intended for pre-DistroAV-rebrand 6.0.0 but now deprecated by `6.0.0_actual` rebranded branch; keep and resolve diffs before `6.0.0_actual` release #960

paulpv commented Jan 11, 2024 •

edited

Loading